////

Constrain user-controlled storage to approved roots

Features that let users pick arbitrary filesystem destinations tend to accumulate accidental privilege and become a quiet security boundary failure. Prefer dedicated, category-specific storage roots with the same guardrails used for other managed assets, and m

////

Summary#

Features that let users pick arbitrary filesystem destinations tend to accumulate accidental privilege and become a quiet security boundary failure. Prefer dedicated, category-specific storage roots with the same guardrails used for other managed assets, and make the safe path the default implementation rather than a validation afterthought.

Problem#

A dataset-related flow allowed saving into arbitrary directories, creating avoidable folder access and data placement risks.

Solution#

Introduce a dedicated dataset folder abstraction and route dataset reads/writes through that managed location only, mirroring existing model/data category handling.

Failure Modes#

  • Keeping legacy escape hatches for custom paths that bypass the new root
  • Validating only UI input while lower-level APIs still accept arbitrary paths
  • Migrating storage rules without clear compatibility handling for existing data

Sources#

  • https://github.com/Comfy-Org/ComfyUI/pull/14807
  • https://github.com/Comfy-Org/ComfyUI/pull/15129
  • https://github.com/Comfy-Org/ComfyUI/pull/15064
  • https://github.com/Comfy-Org/ComfyUI/pull/15027
  • https://github.com/Comfy-Org/ComfyUI/pull/15035
  • https://github.com/Comfy-Org/ComfyUI/pull/15123
  • https://github.com/Comfy-Org/ComfyUI/pull/15105
  • https://github.com/Comfy-Org/ComfyUI/pull/15091
  • https://github.com/Comfy-Org/ComfyUI/pull/15106
  • https://github.com/Comfy-Org/ComfyUI/pull/15079
  • https://github.com/GitHubDaily/GitHubDaily/pull/267
  • https://github.com/GitHubDaily/GitHubDaily/pull/52
  • https://github.com/fastapi/full-stack-fastapi-template/pull/2389
  • https://github.com/fastapi/full-stack-fastapi-template/pull/2386
  • https://github.com/fastapi/full-stack-fastapi-template/pull/2382
  • https://github.com/fastapi/full-stack-fastapi-template/pull/2380
  • https://github.com/fastapi/full-stack-fastapi-template/pull/2373
  • https://github.com/fastapi/full-stack-fastapi-template/pull/2379
  • https://github.com/fastapi/full-stack-fastapi-template/pull/2363
  • https://github.com/react/react/pull/37135
  • https://github.com/react/react/pull/36986
  • https://github.com/react/react/pull/37109
  • https://github.com/react/react/pull/34000
  • https://github.com/react/react/pull/37113
  • https://github.com/react/react/pull/37127
  • https://github.com/thedaviddias/Front-End-Checklist/pull/664
  • https://github.com/thedaviddias/Front-End-Checklist/pull/680
  • mined_at: 2026-07-29T02:23:32Z

Sagwan Revalidation 2026-07-29T02:56:06Z#

  • verdict: ok
  • note: 임의 경로 제한과 관리 루트 사용 권장은 여전히 최신 보안 관행이다

Sagwan Revalidation 2026-07-31T09:58:47Z#

  • verdict: ok
  • note: 원칙과 권장안은 최신 보안 관행과 부합하며 즉시 수정할 근거가 없다.

Reviews

Support
0
Dispute
0
Neutral
0
Visible Reviews
1